✨ feat: 实现基础的任务栏歌词 #777
✨ feat: 实现基础的任务栏歌词 #777
Conversation
Summary of ChangesHello @apoint123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求的核心目标是为应用程序添加任务栏歌词功能，提升用户体验。通过引入一个专门的Rust原生模块，实现了与Windows任务栏的深度集成，能够将歌词窗口嵌入到任务栏中，并根据系统状态动态调整其显示。这一改动为后续在Vue和TypeScript中开发更丰富的歌词动画和交互奠定了坚实的基础，同时最大程度地减少了对原生代码的直接修改。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature: taskbar lyrics. It includes changes to Cargo.lock and Cargo.toml to add the taskbar-lyric crate as a dependency, modifications to electron-builder.config.ts and electron.vite.config.ts to handle the new native module, and additions to electron/main to manage the taskbar lyric window and IPC. The new taskbar-lyric crate contains Rust code for embedding the lyric window in the taskbar and handling system events. The code introduces a new window, IPC handlers, and store configurations for managing the taskbar lyrics. I have identified some areas for improvement, mainly focusing on error handling and code clarity.
| const envEnabled = store.get("taskbar.enabled"); | ||
|
|
||
| const tray = getMainTray(); | ||
| tray?.setTaskbarLyricShow(envEnabled); |
There was a problem hiding this comment.
It's good to see the tray icon being updated based on the taskbar lyric state. However, consider adding a check to ensure tray is not null before calling setTaskbarLyricShow. This will prevent potential errors if the tray hasn't been initialized yet.
if (tray) {
tray.setTaskbarLyricShow(envEnabled);
}| const tray = getMainTray(); | ||
| tray?.setTaskbarLyricShow(show); |
There was a problem hiding this comment.
Similar to the previous comment, ensure tray is not null before calling setTaskbarLyricShow here as well.
if (tray) {
tray.setTaskbarLyricShow(show);
}| } catch (e) { | ||
| processLog.error("[TaskbarLyric] 创建注册表监听器失败", e); | ||
| } |
There was a problem hiding this comment.
The error logging here is good, but consider adding a more user-friendly message to the UI to inform the user that the taskbar lyric feature failed to initialize. This could be done via IPC to the main window.
| if (!success) { | ||
| processLog.error("[TaskbarLyric] 嵌入窗口失败"); | ||
| } |
There was a problem hiding this comment.
Consider adding a more descriptive error message to the UI if embedWindow fails. This will help the user understand why the taskbar lyric is not showing up.
| } catch (e) { | ||
| processLog.error("[TaskbarLyric] 更新布局失败", e); | ||
| } |
There was a problem hiding this comment.
Consider adding a more descriptive error message to the UI if updateLayout fails. This will help the user understand why the taskbar lyric is not showing up.
| } catch (e) { | ||
| processLog.error(e); | ||
| } |
There was a problem hiding this comment.
Consider adding a more descriptive error message to the UI if taskbarLyricNative.restore() fails. This will help the user understand why the taskbar lyric is not being properly restored.
| const taskbarLyrics = lyricData.yrcData.length > 0 ? lyricData.yrcData : lyricData.lrcData; | ||
| playerIpc.sendTaskbarLyrics({ | ||
| lines: toRaw(taskbarLyrics), | ||
| type: lyricData.yrcData.length > 0 ? "word" : "line", | ||
| }); |
There was a problem hiding this comment.
Consider adding a check to ensure taskbarLyrics is not null or empty before sending it via IPC. This will prevent potential errors if there are no lyrics to display.
if (taskbarLyrics && taskbarLyrics.length > 0) {
playerIpc.sendTaskbarLyrics({
lines: toRaw(taskbarLyrics),
type: lyricData.yrcData.length > 0 ? "word" : "line",
});
}1 participant
添加了基础的任务栏歌词功能，歌词的动画效果是基本没有的，只是打好了基础，接下来可以直接写vue和ts代码，应该不用再写原生代码了