Skip to content

Conversation

@kazukokawagawa
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kazukokawagawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求修复了一个问题,即即使启用了隐藏歌词括号的用户设置,专辑名称也未能正确地剔除括号。此更改确保了专辑标题在不同的 UI 组件中能根据用户偏好一致地显示。

Highlights

  • 专辑名称显示逻辑: 在 SongCard.vuePlayerData.vue 组件中,根据用户设置 settingStore.hideLyricBrackets 的状态,为专辑名称的显示引入了条件括号剔除逻辑。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 旨在修复专辑名括号未被正确剔除的问题,但在实现上引入了一个新的 bug:当 hideLyricBrackets 开启且专辑名不存在时,会显示空字符串而不是“未知专辑”。我已经针对这个问题在代码中提出了具体的修改建议。此外,这两个文件中处理专辑名的逻辑存在重复,未来可以考虑提取成一个 computed property 来优化,以提高代码的可维护性。

Comment on lines 135 to 137
settingStore.hideLyricBrackets
? removeBrackets(song.album?.name)
: song.album?.name || "未知专辑"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

当前逻辑存在一个缺陷:当 settingStore.hideLyricBracketstruesong.album?.name 为空时,会显示一个空字符串,而不是预期的“未知专辑”。为了修复这个问题,并使代码更简洁,建议将 || "未知专辑" 的备选逻辑移到三元表达式之外。

            (settingStore.hideLyricBrackets
              ? removeBrackets(song.album?.name)
              : song.album?.name) || "未知专辑"

Comment on lines 142 to 144
settingStore.hideLyricBrackets
? removeBrackets(song.album)
: song.album || "未知专辑"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

同样的问题:当 song.album 为空且 hideLyricBrackets 开启时,会显示空字符串而不是“未知专辑”。

            (settingStore.hideLyricBrackets
              ? removeBrackets(song.album)
              : song.album) || "未知专辑"

Comment on lines 94 to 96
settingStore.hideLyricBrackets
? removeBrackets(musicStore.playSong.album?.name)
: musicStore.playSong.album?.name || "未知专辑"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

此处的逻辑也存在缺陷。当 settingStore.hideLyricBracketstruemusicStore.playSong.album?.name 为空时,会显示一个空字符串,而不是“未知专辑”。建议将 || "未知专辑" 移到三元表达式之外来修复此问题。

            (settingStore.hideLyricBrackets
              ? removeBrackets(musicStore.playSong.album?.name)
              : musicStore.playSong.album?.name) || "未知专辑"

Comment on lines 101 to 103
settingStore.hideLyricBrackets
? removeBrackets(musicStore.playSong.album)
: musicStore.playSong.album || "未知专辑"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

同样的问题:当 musicStore.playSong.album 为空且 hideLyricBrackets 开启时,会显示空字符串而不是“未知专辑”。

            (settingStore.hideLyricBrackets
              ? removeBrackets(musicStore.playSong.album)
              : musicStore.playSong.album) || "未知专辑"

@kazukokawagawa kazukokawagawa added the BUG 这里有一只虫子 label Jan 28, 2026
@kazukokawagawa kazukokawagawa self-assigned this Jan 28, 2026
@imsyy imsyy merged commit b8fddec into dev Jan 28, 2026
4 checks passed
@imsyy imsyy deleted the dev-cy branch January 28, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUG 这里有一只虫子

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants