-
Notifications
You must be signed in to change notification settings - Fork 1.1k
🐞 fix: 专辑没有被正确剔除括号 #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 fix: 专辑没有被正确剔除括号 #775
Conversation
Summary of ChangesHello @kazukokawagawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求修复了一个问题,即即使启用了隐藏歌词括号的用户设置,专辑名称也未能正确地剔除括号。此更改确保了专辑标题在不同的 UI 组件中能根据用户偏好一致地显示。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 旨在修复专辑名括号未被正确剔除的问题,但在实现上引入了一个新的 bug:当 hideLyricBrackets 开启且专辑名不存在时,会显示空字符串而不是“未知专辑”。我已经针对这个问题在代码中提出了具体的修改建议。此外,这两个文件中处理专辑名的逻辑存在重复,未来可以考虑提取成一个 computed property 来优化,以提高代码的可维护性。
src/components/Card/SongCard.vue
Outdated
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(song.album?.name) | ||
| : song.album?.name || "未知专辑" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/Card/SongCard.vue
Outdated
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(song.album) | ||
| : song.album || "未知专辑" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(musicStore.playSong.album?.name) | ||
| : musicStore.playSong.album?.name || "未知专辑" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(musicStore.playSong.album) | ||
| : musicStore.playSong.album || "未知专辑" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄 refactor: 全局设置重构,支持搜索 / 跳转
No description provided.