Open
Conversation
Update master to main project
Include new code for OT variations panel with standard axes according to the MS spec: https://www.microsoft.com/typography/otspec/dvaraxisreg.htm Some minor fixes in the Hebrew code Adjustments to CSS and top panel HTML
Contributor
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added preliminary support for variable fonts utilizing standard axes per this MS spec. It's basically an additional "features" panel that opens alongside the original one, containing the variation sliders.
To add variations support to any language page, you need to include the
otvariations-v10.0.jsscript in your<head>. I've gone ahead and done it forindex-hebrew.phpandindex.php.I've had to make a few minor changes to the css and
top.phpfiles, but avoided breaching existing files too much in order not to break existing functionality. Hopefully everything else is intact...If you find this useful, go ahead and merge, but I will be happy if this is also just used as a reference for a better solution!