Restore cross checking code, part 1 #1575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 32361f7.
ahomescu
force-pushed
the
ahomescu/restore_cross_checks_part1
branch
from
1b3ac45 to
9731c3a
Compare
kkysen
reviewed
Jan 29, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Don't we need to add cross-checks either to members or exclude in the top-level Cargo.toml?
Comment on lines
+1265
to
+1272
| out_items.push( | ||
| mk().single_attr("macro_use") | ||
| .extern_crate_item("c2rust_xcheck_derive", None), | ||
| ); | ||
| out_items.push( | ||
| mk().single_attr("macro_use") | ||
| .extern_crate_item("c2rust_xcheck_runtime", None), | ||
| ); |
Contributor
There was a problem hiding this comment.
I don't think we need #[macro_use]s anymore.
Comment on lines
+1
to
+4
| #ifndef CROSS_CHECKS_H | ||
| #define CROSS_CHECKS_H | ||
|
|
||
| #pragma once |
Comment on lines
+44
to
+55
| [dependencies.c2rust-xcheck-plugin] | ||
| version = "*" | ||
|
|
||
| [dependencies.c2rust-xcheck-derive] | ||
| version = "*" | ||
|
|
||
| [dependencies.c2rust-xcheck-runtime] | ||
| version = "*" | ||
| features = ["libc-hash", "fixed-length-array-hash"] | ||
|
|
||
| [dependencies.c2rust-xcheck-backend-{{cross_check_backend}}] | ||
| version = "*" |
Contributor
There was a problem hiding this comment.
Suggested change
| [dependencies.c2rust-xcheck-plugin] | |
| version = "*" | |
| [dependencies.c2rust-xcheck-derive] | |
| version = "*" | |
| [dependencies.c2rust-xcheck-runtime] | |
| version = "*" | |
| features = ["libc-hash", "fixed-length-array-hash"] | |
| [dependencies.c2rust-xcheck-backend-{{cross_check_backend}}] | |
| version = "*" | |
| c2rust-xcheck-plugin = "*" | |
| c2rust-xcheck-derive = "*" | |
| c2rust-xcheck-runtime = { version = "*", features = ["libc-hash", "fixed-length-array-hash"] } | |
| c2rust-xcheck-backend-{{cross_check_backend}} = "*" |
Also, what's the reason for "*" instead of a specific version?
Comment on lines
+4
to
+5
| version = "0.9.0" | ||
| edition = "2018" |
Comment on lines
+135
to
+136
| # clang 3.6.0 is known to work; 3.4.0 known to not work. | ||
| ensure_clang_version([3, 6, 0]) |
Contributor
There was a problem hiding this comment.
Did you test on a more recent clang? Pretty sure we don't support anything anywhere near this old anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.