Conversation
This mirrors what the other value type provides, for now private and only for IfdPointer which we need for iterating an existing directory.
Member
Author
|
Todo: Exif has an unrelated
It's not clear if we should just support this for all files. Technically only allowed in EXIF private directories but I have yet to encounter this otherwise. And we could fall back to ignoring the tag when UTF-8 validation fails. I don't know yet, so it's not part of this PR. Those tags are thrown away for now. |
197g
force-pushed
the
copy-or-extract-exif
branch
2 times, most recently
from
6452b1c to
abaa3cf
Compare
This allows it to address the case of copying all EXIF data into a separate file. And as soon as our decoder can handle files without any image data (missing any stripoffsets, etc.) in ways that do not return errors we can hopefully do the opposite and merge the data again.
197g
force-pushed
the
copy-or-extract-exif
branch
from
abaa3cf to
32dda6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main complexity here is that firstly the entries are a tree and secondly some entries are not-allowed or ill-advised when changing the photometric interpretation / planar configuration of the image data. So we have two use-cases here:
This is solved by classifying tags through a
TagFiltertype. (As an experiment, that could include a 'Personally Identifiable Data' qualification but that is not super well-defined and I'd like to externalize the legal aspect in that through future extension methods, not seeing much adoption for this use without that, too). So there'sAllfor copying tags just through their type and count andKnownto ensure we at least semantically recognize the tags as part of EXIF v3 which enables us to remove tags that would conflict with a changed photometric interpretation / planar configuration.