Add libm dependency #530
Open
Add libm dependency #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `libm` optional feature (not enabled by default) to turn the corresponding feature in the `num-traits` dependency crate. The commit updates some default SI units and changes `Float` exporting rules. The `libm` crate enables math support for `#![no_std]` crates, including trigonometric functions. Those are implemented for `Angle` and `Ratio` quantities, and now are supported and usable in a wider area of cases.
The `libm` can be used in more cases enabled with the `std` feature by default. Various non-trigonometric functions (power, square root, etc.) can be used with `libm` support in `#![no_std]` environment.
|
see also #309 |
Author
|
Thanks for pointing that out! I see... I'm not the first one to stumble over lack of float-related operations in What would be the best strategy at the current moment? Should I invest some time into updating my changes in favor of suggested modifications in #309 or attempt to update the #309 to the current state of That way or another, thanks for considering my pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
libmoptional feature (not enabled by default) to turn the corresponding feature in thenum-traitsdependency crate. The commit updates some default SI units and changesFloatexporting rules.The
libmcrate enables math support for#![no_std]crates, including trigonometric functions. Those are implemented forAngleandRatioquantities, and now are supported and usable in a wider area of cases.