added alias for EnergyDensity #518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calbaker
commented
May 18, 2025
| "pound-force per square inch", "pounds-force per square inch"; | ||
| @psi: 6.894_757_E3; "psi", "pound-force per square inch", "pounds-force per square inch"; | ||
| @torr: 1.333_224_E2; "Torr", "torr", "torr"; | ||
| @joule_per_cubic_meter: prefix!(kilo) / prefix!(kilo); "J/m³", |
Author
There was a problem hiding this comment.
@iliekturtles , please scrutinize my use of prefix! here as I'm a little unsure about this.
|
Does |
Owner
|
@calbaker, rather than defining a type alias, do you mind reworking the PR to have a new energy density quantity? See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.