-
Notifications
You must be signed in to change notification settings - Fork 36
Dual ISO processing #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Dual ISO processing #306
Conversation
This update focuses primarily on solving 2 of the biggest dual ISO issues: the flickering issue and artifacts in blown highlights areas affecting lower bit depth footage (e.g. 12-bit, 10-bit…). Added manual control over 3 most crucial parameters for proper exposure blending: horizontal pattern, exposure correction, and black delta. Big performance boost by enabling multithreading. It also includes several minor UI updates/fixes not specific to dual ISO.
bring back spaces for better readability, better precision for black level spinbox, compatibilty between old and new dual iso receipts, bring dual iso help to tooltip, cleanup unused code
was missing for test file
|
Test:
|
|
Export successful now. |
|
Thanks for testing! Yes, the difference using AMaZE multithreaded was to be expected and is one of the downsides of this method. Looks your example uses 2 threads. I don't remember my test footage which was showing this also in a standard clip with basic AMaZE debayering. In those days I switched often to RCD - here multithreading was realized in a different way and you don't get those artifacts. Would this also work with DualISO (sry... I did not try to understand to much in detail how exactly DualISO works)? |

Using the changes from @fijha and inserting my requests mentioned in the PR.