Skip to content

AMD module name for KnockoutJS should be 'knockout'. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schinckel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AMD module name for KnockoutJS should be 'knockout'. #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f2b2b5
Fixup to use proper ko name.
schinckel Mar 31, 2013
9446010
The canonical name for knockout should not be ko.
schinckel Mar 31, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/koExternalTemplateEngine-amd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// This is the AMD style module version of the KO External Template Engine
// If you need the standard 'js lib' version, please go to https://github.com/ifandelse/Knockout.js-External-Template-Engine

define(['ko','jquery', 'infuser'], function(ko, jQuery, infuser){
define(['knockout','jquery', 'infuser'], function(ko, jQuery, infuser){

var ExternalTemplateSource = function(templateId, options) {
var self = this, origAfterRender;
Expand Down
2 changes: 1 addition & 1 deletion lib/koExternalTemplateEngine-amd.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/koExternalTemplateEngine-amd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// This is the AMD style module version of the KO External Template Engine
// If you need the standard 'js lib' version, please go to https://github.com/ifandelse/Knockout.js-External-Template-Engine

define(['ko','jquery', 'infuser'], function(ko, jQuery, infuser){
define(['knockout','jquery', 'infuser'], function(ko, jQuery, infuser){

//import("ExternalTemplateSource.js");
//import("TemplateEngine.js");
Expand Down