Skip to content

add ground temperature 1m as option to weather data #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 55 commits into
base: dev
Choose a base branch
from
Open

add ground temperature 1m as option to weather data #1351

wants to merge 55 commits into from

Conversation

@pierrepetersmeier
Copy link
Contributor

@pierrepetersmeier pierrepetersmeier commented Jun 26, 2025

Resolves #1343

@pierrepetersmeier pierrepetersmeier self-assigned this Jun 26, 2025
@danielfeismann danielfeismann added enhancement New feature or request labels Jun 26, 2025
danielfeismann
danielfeismann requested changes Jul 3, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get to all of it. Just a first view thoughts that imho needs to be adapted. As well it might get easier since it would reduce the amount of changes.

@danielfeismann danielfeismann added this to the Version 8.2 milestone Jul 25, 2025
danielfeismann
danielfeismann requested changes Aug 14, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks already quite ok, but I guess some parts can be improved.

danielfeismann
danielfeismann requested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we're getting closer and by the way exploited another issue, which make me stopping my review within the tests. But please start alreay with my comments below

@pierrepetersmeier pierrepetersmeier force-pushed the pp/#1343-add-ground-temperature-1m-as-option-to-weather-data branch from b09a3ba to aa481ca Compare November 6, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielfeismann danielfeismann danielfeismann requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@pierrepetersmeier pierrepetersmeier

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 8.2

Development

Successfully merging this pull request may close these issues.

Add ground temperature (1m) as option to weather data

3 participants

@pierrepetersmeier @danielfeismann