Skip to content

Conversation

@rix133
Copy link
Contributor

@rix133 rix133 commented Oct 17, 2025

Bugs
Bug fix: addressed #251

Enhancements to documentation and parameter handling:

  • Added detailed descriptions to the documentation of combineRDBESDataObjects and createRDBESDataObject, clarifying behavior when combining or importing objects with different hierarchies and how to specify which hierarchy to use. [1] [2] [3]
  • Improved the handling and documentation of ... (ellipsis) parameters in createRDBESDataObject, providing clear guidance for users on strictness, verbosity, and hierarchy selection.

Validation and warning logic for mixed hierarchies:

Improvements to ID table creation:

  • Enhanced createTableOfRDBESIds now coded in data.table, with more robust merging logic for different lower hierarchies, added informative console output, and clarified handling of special cases (e.g., BV table merges depending on hierarchy). [1] [2]

erosquesada and others added 30 commits October 15, 2025 14:32
ISrecordType value updated
…esdataobjects

Add warning when combining RDBESDataObjects from different hierarchies
Merge pull request #244 from ices-tools-dev/dev
update to latest RDBES version (April 2025)
code made more consistent and easy to compare between different scripts
deleted old migration code
created a new run_all script

textbooks successfully uploaded 16/10/2025

#248 #247
@rix133 rix133 requested a review from Copilot October 17, 2025 12:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses bug #251 and implements several improvements to documentation, parameter handling, validation logic, and ID table creation within the RDBEScore package.

Key changes:

  • Fixed data type validation to treat numeric and integer types as compatible (#251)
  • Enhanced documentation for combineRDBESDataObjects() and createRDBESDataObject() to clarify hierarchy handling and parameter options
  • Added hierarchy validation to prevent/warn when combining objects from different hierarchies

Reviewed Changes

Copilot reviewed 39 out of 41 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
R/validateRDBESDataObjectDataTypes.R Fixed bug #251 by treating integer/numeric as compatible in both directions
R/combineRDBESDataObjects.R Added hierarchy checking logic with strict parameter support
R/createRDBESDataObject.R Expanded documentation for ... parameter and hierarchy selection
R/createTableOfRDBESIds.r Enhanced merging logic for different lower hierarchies with improved console output
R/lowerTblData.R Updated to preserve intermediate IDs in the hierarchy traversal path
R/importRDBESDataZIP.R Corrected spelling from "Hierachy" to "Hierarchy"
man/*.Rd Updated documentation files to reflect code changes
tests/testthat/*.R Added/updated tests for data type validation and object combination
vignettes/*.Rmd Added examples for inverse filtering and updated code snippets
data-raw/exampleData/TextBookExamples/*.R Build scripts updated with new fields and corrected structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rix133 rix133 requested a review from nmprista October 17, 2025 12:44
Copy link
Contributor

@nmprista nmprista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first sight, looks ok

@nmprista nmprista merged commit 9077812 into main Oct 17, 2025
15 checks passed
@nmprista nmprista deleted the v.0.3.5 branch October 17, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants