Skip to content

Conversation

@erosquesada
Copy link
Contributor

@erosquesada erosquesada commented Oct 15, 2025

Now the function takes into account the differences in low-hierarchies mentioned here.
This allow to process data belonging to low-hierarchies having no FMid, and hence allow breaking the code in functions relying on this basis (e.g. those in RDBESvisualise package). The code was written in dplyr, then translated in data.table.
Please @nmprista or @Kasia-MIR to check ahead of merging. @Kasia-MIR, once this is merged we can proceed.

@erosquesada erosquesada requested review from Kasia-MIR and nmprista and removed request for nmprista October 15, 2025 12:55
@erosquesada erosquesada marked this pull request as draft October 15, 2025 13:30
@erosquesada erosquesada reopened this Oct 15, 2025
@erosquesada erosquesada marked this pull request as ready for review October 15, 2025 14:00
@Kasia-MIR
Copy link
Contributor

first check:
`

RDBESdataObject

library(RDBEScore)
library(data.table)
H1 <- createRDBESDataObject(input = "./TableFormat141025/All_H/2025_10_14_125156.zip", Hierarchy = 1)

use createTableOfRDBESIds

H1_ids <- createTableOfRDBESIds(H1)

#check 1
#BVid without BVfishid
case1 <-H1_ids[is.na(H1_ids$BVid) & !is.na(H1_ids$BVfishId),]
if(nrow(case1)!=0){
stop("Error: BVfishId without BVid")
}
case2 <-H1_ids[!is.na(H1_ids$BVid) & is.na(H1_ids$BVfishId),]
if(nrow(case2)!=0){
stop("Error: BVid without BVfishId")
}
`

Copy link
Contributor

@Kasia-MIR Kasia-MIR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bug with BVfishId.

@Kasia-MIR Kasia-MIR merged commit 984ad52 into dev Oct 16, 2025
@Kasia-MIR Kasia-MIR deleted the issue237 branch October 16, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants