Add package traits for compile-time configuration #245
+55
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce Swift 6.1 manifest with traits for optional features: - noReader, noWriter, noIncrementalReader, noUtilities - noFastFloatingPoint, strictStandardJSON, noUTF8Validation Rename original manifest to [email protected] to maintain backward compatibility with Swift 5.x and 6.0.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 2 2
Lines 7686 7686
=======================================
Hits 7570 7570
Misses 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #244
yyjson provides several compile-time options via C preprocessor macros that allow developers to disable unused features and reduce binary size. With Swift 6.1's package traits, these options are now configurable directly from Swift Package Manager, making it easy for Swift projects to customize their yyjson builds without modifying source files or managing custom build settings.
This PR adds a Swift 6.1 package manifest with traits for optional features:
noReader,noWriter,noIncrementalReader,noUtilities,noFastFloatingPoint,strictStandardJSON,noUTF8Validation.To maintain backwards compatibility, we take advantage of version-specific manifests. This PR renames the original manifest to
[email protected], which Swift versions before 6.1 will fall back to.We use this approach currently in mattt/swift-yyjson to allow package consumers to tailor their installation according to their particular needs. If this PR is merged and a new minor release is cut, we'll be able to depend directly on this repo as a package dependency, rather than vendoring it as we currently do.