Skip to content

fix(ManageTripTracking): Don't repeat departure notif when rerouting. #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
binh-dam-ibigroup wants to merge 6 commits into
base: gmap-pending-fixes
Choose a base branch
from
Open

fix(ManageTripTracking): Don't repeat departure notif when rerouting. #360

binh-dam-ibigroup wants to merge 6 commits into from

Conversation

@binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Jan 8, 2026 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR improves rerouting by not sending a "User has departed " after rerouting occurs.

Behind the scenes, journeyState.lastNotifications is reset when starting a new live tracking session.

@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request Jan 9, 2026
Open
3 tasks
@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as ready for review January 26, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@br648 br648 Awaiting requested review from br648

Assignees

@br648 br648

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@binh-dam-ibigroup @br648