Display Feed Publish Status on List of Feeds #1044
Conversation
josh-willis-arcadis
changed the title
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
First round of comments, but note that I still need to play around with it.
|
|
||
| // eslint-disable-next-line complexity | ||
| render (): React$Element<"div"> { | ||
| const { |
There was a problem hiding this comment.
Set the button's enabled/disabled state, content, and color using the new publishState from FeedVersionSummary? (The variables for the explanation message if publishing is blocked should be retained.)
There was a problem hiding this comment.
@binh-dam-ibigroup We would need to either prop drill the new publishState here or a backend change will be necessary to add this data. This page uses the feedversionsummaries?feedSourceId= endpoint. I will reach out about adding the publishState to this endpoint.
There was a problem hiding this comment.
@josh-willis-arcadis Okay that's fine, I am going to approve this PR and you can reuse publishState in a subsequent PR.
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Could you reuse publishState in FeedVersionActionsMTC? (https://github.com/ibi-group/datatools-ui/pull/1044/files#r2665403992)
|
@josh-willis-arcadis Branch |
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Conditional approval, please add the missing entries in the other language files.
josh-willis-arcadis
assigned
daniel-heppner-ibigroup and unassigned
josh-willis-arcadis
| this.setState({ elapsed: '' }) | ||
| return | ||
| } | ||
| const human = humanizeDuration(Date.now() - ms, { largest: 2 }) |
There was a problem hiding this comment.
Is there a way to just round to whole seconds? (screenshot below shows current behavior displaying millis)
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
Okay this looks good! I was caught up on the interval setup in the new component but now I'm seeing the reason you have that is to get Date.now() again
daniel-heppner-ibigroup
assigned
josh-willis-arcadis and unassigned
daniel-heppner-ibigroup
Checklist
devbefore they can be merged tomaster)Description
Uses new data contained in
FeedSourceSummaryto display the publish status of a feed in theFeedSouceTablecomponent. Uses ibi-group/datatools-server#634German and Polish language files have been added back after a git error on my end.
