IBX-11146: Test for solr search with many (50+) languages#703
Open
IBX-11146: Test for solr search with many (50+) languages#703
Conversation
ViniTou
force-pushed
the
ibx-11146-integration-test-for-solr-languages
branch
from
38650d4 to
67d13bb
Compare
ViniTou
force-pushed
the
ibx-11146-integration-test-for-solr-languages
branch
from
67d13bb to
5756a07
Compare
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
approved these changes
Jan 20, 2026
tests/integration/Core/Repository/SearchServiceManyLanguagesTest.php
Outdated
Show resolved
Hide resolved
barw4
reviewed
Jan 29, 2026
|
|
||
| try { | ||
| $languageService->createLanguage($langCreateStruct); | ||
| } catch (Exception $e) { |
Contributor
There was a problem hiding this comment.
We could narrow it down to \Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException
| $languages[] = $code; | ||
| } | ||
|
|
||
| // Perform search with all languages |
Contributor
There was a problem hiding this comment.
Seems obvious, maybe let's remove it?
alongosz
reviewed
Jan 29, 2026
| } catch (Exception $e) { | ||
| $this->fail('Search failed with many languages: ' . $e->getMessage()); | ||
| } | ||
| $this->expectNotToPerformAssertions(); |
Member
There was a problem hiding this comment.
I feel like we should assert to some minimal extent if the result of findContent makes sense.
ViniTou
force-pushed
the
ibx-11146-integration-test-for-solr-languages
branch
from
042bc24 to
d662280
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: