Abbility to remove tags #807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional changes:
Changed the name of private function list_add_tags_to_subscriber to list_tags_to_subscriber
Changed private function merge_and_format_member_tags to accept a tag array with status active or inactive. (add/remove)
Removed array_unique(array_merge($mailchimp_tags, $new_tags), SORT_REGULAR); from merge_and_format_member_tags
Visual changes:
Added a "remove_subscriber_tags" option to Form > Settings that takes a comma separated list of tags to remove
Renamed the settings fields to "Add tags" and "Remove tags (was Add subscriber tags)
Unit tests:
Testing:
All the form submissions had the expected result of added tags being added, removed tags being removed and unmentioned tags remaining active.
Tags with status inactive were removed if the subscriber had them, the tags not existing or the subscriber not having these tags assigned did not cause any error
The tags with status active and the tags without status explicitly set were added
Tags that are just a string instead of an array were added, for backwards compatibility.