Fix sample generation for scalar inputs#292
Open
nsfinkelstein wants to merge 1 commit intoibab:masterfrom
nsfinkelstein:FIX-SCALAR-GENERATION
Open
Fix sample generation for scalar inputs#292nsfinkelstein wants to merge 1 commit intoibab:masterfrom nsfinkelstein:FIX-SCALAR-GENERATION
nsfinkelstein wants to merge 1 commit intoibab:masterfrom
nsfinkelstein:FIX-SCALAR-GENERATION
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample generation with scalar inputs is broken. When it is reshaped in
predict_proba, it is given too few dimensions. This pull requests corrects the number of dimensions.Here is a simple reproducible example.
Set the value of
wavenet_params.jsonto the following:Training:
Generating (before the fix):
Generating (after the fix):