Skip to content

Replace EOL failure crate with thiserror for error handling #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cango91 wants to merge 1 commit into
base: release
Choose a base branch
from
Open

Replace EOL failure crate with thiserror for error handling #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ documentation = "https://jordanbray.github.io/chess/chess/index.html"
[dependencies]
arrayvec = "0.5.1"
nodrop = "0.1.14"
failure = "0.1.6"
thiserror = "2.0.12"
tracing = { version = "0.1.37", optional = true }

[features]
Expand Down Expand Up @@ -46,7 +46,7 @@ opt-level = 3

[build-dependencies]
rand = { version = "0.7.2", default_features = false, features = ["small_rng"] }
failure = "0.1.6"
thiserror = "2.0.12"

[dev-dependencies]
criterion = "0.3"
Expand Down
20 changes: 10 additions & 10 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,35 @@
use failure::Fail;
use thiserror::Error;

/// Sometimes, bad stuff happens.
#[derive(Clone, Debug, Fail)]
#[derive(Clone, Debug, Error)]
pub enum Error {
/// The FEN string is invalid
#[fail(display = "Invalid FEN string: {}", fen)]
#[error("Invalid FEN string: {fen}")]
InvalidFen { fen: String },

/// The board created from BoardBuilder was found to be invalid
#[fail(
display = "The board specified did not pass sanity checks. Are you sure the kings exist and the side to move cannot capture the opposing king?"
#[error(
"The board specified did not pass sanity checks. Are you sure the kings exist and the side to move cannot capture the opposing king?"
)]
InvalidBoard,

/// An attempt was made to create a square from an invalid string
#[fail(display = "The string specified does not contain a valid algebraic notation square")]
#[error("The string specified does not contain a valid algebraic notation square")]
InvalidSquare,

/// An attempt was made to create a move from an invalid SAN string
#[fail(display = "The string specified does not contain a valid SAN notation move")]
#[error("The string specified does not contain a valid SAN notation move")]
InvalidSanMove,

/// An atempt was made to create a move from an invalid UCI string
#[fail(display = "The string specified does not contain a valid UCI notation move")]
#[error("The string specified does not contain a valid UCI notation move")]
InvalidUciMove,

/// An attempt was made to convert a string not equal to "1"-"8" to a rank
#[fail(display = "The string specified does not contain a valid rank")]
#[error("The string specified does not contain a valid rank")]
InvalidRank,

/// An attempt was made to convert a string not equal to "a"-"h" to a file
#[fail(display = "The string specified does not contain a valid file")]
#[error("The string specified does not contain a valid file")]
InvalidFile,
}