Skip to content

Add copyright 2026 headers for source code#22

Merged
jprendes merged 2 commits intohyperlight-dev:mainfrom
dblnz:add-copyright-headers
Feb 27, 2026
Merged

Add copyright 2026 headers for source code#22
jprendes merged 2 commits intohyperlight-dev:mainfrom
dblnz:add-copyright-headers

Conversation

@dblnz
Copy link
Contributor

@dblnz dblnz commented Feb 25, 2026

Description

This PR adds copyright headers for hyperlight-js source code

A couple of remarks:

  • Added CI check for license headers
  • Test files are included
  • I added 2026 copyright
  • Are there other files that need to contain the headers?

@dblnz dblnz added the kind/documentation Documentation changes label Feb 25, 2026
@simongdavies
Copy link
Contributor

LGTM, maybe we should add a PR check to ensure that the header is present in all new/updated files, that will prevent this reoccurring, I think we have one in hyperlight.

Copy link
Contributor

@simongdavies simongdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only question I have is about teh c stubds, maybe @jprendes knows the origin of those

@jsturtevant
Copy link
Contributor

LGTM, maybe we should add a PR check to ensure that the header is present in all new/updated files, that will prevent this reoccurring, I think we have one in hyperlight.

https://github.com/hyperlight-dev/hyperlight/blob/main/dev/check-license-headers.sh

2026 is correct for this since they just got released

@dblnz dblnz force-pushed the add-copyright-headers branch 3 times, most recently from aec9e1d to 5f78422 Compare February 27, 2026 10:31
@jprendes
Copy link
Contributor

The only question I have is about teh c stubds, maybe @jprendes knows the origin of those

The stubs are ours, except for the __secs_to_tm function, which is part of musl:
https://git.musl-libc.org/cgit/musl/tree/src/time/__secs_to_tm.c

I realise we should aknowledge that somewhere, or rewrite it without basing it on musl.

I think the right thing to do is to split __secs_to_tm into its own file, with the correct license and notice, and put the header for the rest of localtime_r.

@jprendes
Copy link
Contributor

I'll rewrite all the stubs in rust, I propose you go ahead as it is, as the concern with the stub will be sorted with the rewrite

Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
- Also reorder CI jobs alphabetically

Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
@dblnz dblnz force-pushed the add-copyright-headers branch from 5f78422 to 5624ac3 Compare February 27, 2026 11:53
@dblnz
Copy link
Contributor Author

dblnz commented Feb 27, 2026

I'll rewrite all the stubs in rust, I propose you go ahead as it is, as the concern with the stub will be sorted with the rewrite

I've updated to remove the stub file containing the musl function

@jprendes jprendes merged commit 1773722 into hyperlight-dev:main Feb 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants