fix: preserve managed agent config during deserialization #1955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1849
When deserializing an agent with managed agents via
from_dict(), the parent agent's**kwargswere being incorrectly passed to child agents. This caused child agent configurations (especiallyadditional_authorized_imports) to be overwritten by the parent's configuration.Root Cause
In
MultiStepAgent.from_dict(), line 1043:The
**kwargscontains the parent agent'scode_agent_kwargs(includingadditional_authorized_imports), which then overrides the child agent's own serialized configuration inCodeAgent.from_dict().Fix
Remove
**kwargsfrom the managed agent deserialization call:Each managed agent should use only its own serialized configuration, not inherit the parent's kwargs.
Test Plan
test_from_dict_preserves_managed_agent_authorized_importsthat:additional_authorized_imports=["sympy"]to_dict()/from_dict()sympyin its authorized_imports