-
Notifications
You must be signed in to change notification settings - Fork 6
Slack messages for derived/primary datasets #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gesinaphillips
wants to merge
32
commits into
devel
Choose a base branch
from
phillips/notify_derived_slack
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_state to message primary about derived failures
…, setting error on primary for failure in derived
e060b3b to
638cb3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major thing to review
utils.pythonop_set_dataset_stateand how it is called in DAGs.Changes to
utils.pythonop_set_dataset_stateMessageManageraware of when a processing pipeline is involved.parent_dataset_uuid_callable: add parent ID so we can message based on the primary dataset when a pipeline failspipeline_name: we can determine whetherMessageManagerwas triggered by a pipeline; plus now we have richer messaging datacall_message_managerswhen there is no UUID passed (because creation of derived dataset failed--this skipsStatusChanger) to trigger messages for primary dataset.Ergonomic changes
MessageManagernow takes amessagesdict param where before it expected several different parameters. This removes several messaging-only params fromStatusChangerwhile allowing messaging data to still be passed in explicitly.MessageManagerclass parses themessagesdict and turns expected optional values into properties.StatusChangersignature to usemessagesparam.StatusChangercalls.status_utils.py > call_message_managersto allow use of messaging classes outside ofStatusChanger.MessageManageras strings.status_utils.py > get_status_enumto status utils for easier conversion between metadata status and Statuses enum.SlackMessagerun_idandprocessing_pipelineparams.dataset_error_derived- error after creating derived datasetdataset_error_primery_pipeline- error on the primary dataset occurred while running processing pipelinedataset_new- base class, does nothingdataset_new_derived- a new derived dataset has been createddataset_qa_derived- a derived dataset has reached QATests