Skip to content

Comments

Add GOOGLE_GENAI_USE_VERTEXAI to setup script manual instructions#2

Merged
huan merged 2 commits intomainfrom
copilot/improve-if-else-branch-coverage
Nov 10, 2025
Merged

Add GOOGLE_GENAI_USE_VERTEXAI to setup script manual instructions#2
huan merged 2 commits intomainfrom
copilot/improve-if-else-branch-coverage

Conversation

Copy link

Copilot AI commented Nov 10, 2025

The setup script automatically sets GOOGLE_GENAI_USE_VERTEXAI when gh CLI is available but omits it from manual setup instructions, leaving users without gh CLI unable to configure Vertex AI.

Changes

  • Automatic setup: Added GOOGLE_GENAI_USE_VERTEXAI to gh variable set commands (line 458)
  • Manual setup: Added variable documentation to else block with usage note (lines 477-480)
# When gh CLI is available
gh variable set GOOGLE_GENAI_USE_VERTEXAI --body "true" --repo "${GITHUB_REPO}"

# When gh CLI is not available (manual instructions)
echo "🤖 Variable Name: GOOGLE_GENAI_USE_VERTEXAI"
echo "   Variable Value: true"
echo "   (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)"

This establishes parity between both setup paths and documents the alternative GOOGLE_GENAI_USE_GCA variable for Code Assist users.

Original prompt

This section details on the original issue you should resolve

<issue_title>Improve code to cover full if/else branches</issue_title>
<issue_description>apply changes based on this feedback

The new GOOGLE_GENAI_USE_VERTEXAI variable is set automatically when gh CLI is available, but it's not included in the manual setup instructions in the else block (lines 462-477). Users without the gh CLI won't know to set this variable manually. Consider adding documentation for this variable in the else block, similar to the other variables.

</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…manual setup

Co-authored-by: huan <1361891+huan@users.noreply.github.com>
Copilot AI changed the title [WIP] Improve code to document GOOGLE_GENAI_USE_VERTEXAI variable Add GOOGLE_GENAI_USE_VERTEXAI to setup script manual instructions Nov 10, 2025
Copilot AI requested a review from huan November 10, 2025 19:12
Copy link
Owner

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan marked this pull request as ready for review November 10, 2025 19:33
Copilot AI review requested due to automatic review settings November 10, 2025 19:33
@huan huan merged commit 0ac8872 into main Nov 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the GOOGLE_GENAI_USE_VERTEXAI variable to both automatic and manual setup paths in the workload identity setup script, ensuring users without the gh CLI can properly configure Vertex AI.

Key Changes:

  • Added automatic setting of GOOGLE_GENAI_USE_VERTEXAI when gh CLI is available
  • Added manual instructions for GOOGLE_GENAI_USE_VERTEXAI with explanatory note about the alternative GOOGLE_GENAI_USE_GCA variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

echo ""
echo "🤖 Variable Name: GOOGLE_GENAI_USE_VERTEXAI"
echo " Variable Value: true"
echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)"
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parenthetical note mentions using GOOGLE_GENAI_USE_GCA but doesn't provide guidance on which variable to set or if both can be set simultaneously. Consider clarifying that these are mutually exclusive options, or explain that users should choose one based on their needs. For example: "(Set to 'true' to use Vertex AI. Alternatively, use GOOGLE_GENAI_USE_GCA='true' for Code Assist instead)"

Suggested change
echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)"
echo " (Set to 'true' to use Vertex AI. Alternatively, set GOOGLE_GENAI_USE_GCA='true' for Code Assist. These options are mutually exclusive; set only one based on your needs.)"

Copilot uses AI. Check for mistakes.
@huan huan deleted the copilot/improve-if-else-branch-coverage branch November 10, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve code to cover full if/else branches

2 participants