Set TCP_NODELAY on the TcpStream to disable Nagle's algorithm.#900
Closed
kyrias wants to merge 1 commit intohttp-rs:mainfrom
Closed
Set TCP_NODELAY on the TcpStream to disable Nagle's algorithm.#900kyrias wants to merge 1 commit intohttp-rs:mainfrom
TCP_NODELAY on the TcpStream to disable Nagle's algorithm.#900kyrias wants to merge 1 commit intohttp-rs:mainfrom
Conversation
Due to the way the `async-h1` crate writes HTTP responses to the `TcpStream` the head and body end up in separate write calls to the underlying socket. If we're responding to more than one request received from the same `TcpStream` it means that we did two sends and then tried to read. That read can take up to 500 milliseconds to complete due to bad interactions between Nagle's algorithm and delayed ACK. (In practice this is 40 ms on Linux.) Disabling Nagle's algorithm works around this until `async-h1` is fixed. http-rs/async-h1#199 Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Contributor
Author
|
Finally got around to figuring out how to fix this properly in async-h1. C.f. http-rs/async-h1#200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the way the
async-h1crate writes HTTP responses to theTcpStreamthe head and body end up in separate write calls to the underlying socket. If we're responding to more than one request received from the sameTcpStreamit means that we did two sends and then tried to read. That read can take up to 500 milliseconds to complete due to bad interactions between Nagle's algorithm and delayed ACK. (In practice this is 40 ms on Linux.)Disabling Nagle's algorithm works around this until
async-h1is fixed.http-rs/async-h1#199