Refactor/arch #23
Open
Refactor/arch #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
In this merge request, I will introduce System Sets into our main logic |
This commit resolves a persistent UI bug where icon titles would flicker and jitter when their visibility was toggled (via the 'T' key) or during hover animations. The root cause was two conflicting systems updating transforms independently: one for icon hover animations and another manually setting text positions. This led to synchronization issues and visual instability. The solution was to refactor the UI to use Bevy's parent-child entity hierarchy: - Icon title text entities are now spawned as children of their corresponding icon entity. - This leverages Bevy's transform propagation, ensuring titles automatically and smoothly follow their parent icon's position, rotation, and scale. - The obsolete system for manual text position updates has been removed. Additional improvements in this commit: - **System Order:** Introduced s (, , ) to enforce a clear and predictable execution order. - **Hover/Drag:** Improved hover detection to respect icon scaling and fixed drag-and-drop to correctly select the topmost icon. - **Modularity:** Extracted application launcher logic into a dedicated module. - **Config:** Added a field to the configuration to control title text size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.