HHH-19906 JsonGeneratingVisitor#visit doesn't handle plural types correctly #11200
+180
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
reviewed
Nov 6, 2025
| //noinspection unchecked | ||
| final JavaType<Object> elementJavaType = ((BasicPluralJavaType<Object>) basicType.getJdbcJavaType()).getElementJavaType(); | ||
| final var elementJdbcType = ((ArrayJdbcType) basicType.getJdbcType()).getElementJdbcType(); | ||
| final Object domainArray = basicType.convertToRelationalValue( value ); |
Member
There was a problem hiding this comment.
I think you can keep on relying on Object[] and hence keep all the code as it is. You just have to use basicType.getJavaType().unwrap( value, Object[].class, options ) here.
Member
Author
There was a problem hiding this comment.
That's what I intuitively did initially as well, but then I realized that unwrap would cause additional array instantiations and/or iterations of the values in case the original type is not exactly Object[] so I went this route.
We could still use that as a fall-back, though I don't think there are cases where the value is not either an array or an instance of java.util.Collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19906
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.