Skip to content

feat: leverage the heroku credential manager for auth #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelmalave wants to merge 5 commits into
base: feat/credential-mgr-integration
Choose a base branch
from
Open

feat: leverage the heroku credential manager for auth #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2161b3d
updates to leverage the heroku credential manager for auth
michaelmalave Mar 19, 2026
9ad7058
updating with npm token to access private dependency
michaelmalave Mar 19, 2026
5e6985e
updating the version of credential manager to the beta
michaelmalave Mar 20, 2026
ba8c5bc
preloading credentials in Command.init so commands that check this.he…
michaelmalave Mar 20, 2026
67f0f03
update integration with tests to cover credential preload, getAuth, a…
michaelmalave Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: 22.x
registry-url: https://registry.npmjs.org
cache: npm
- run: npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN_HEROKU_CREDENTIAL_MANAGER }}
- name: linting
run: npm run lint

Expand All @@ -28,7 +31,11 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
registry-url: https://registry.npmjs.org
cache: npm
- run: npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN_HEROKU_CREDENTIAL_MANAGER }}
- name: unit tests
run: npm test
- name: linting
Expand Down
2 changes: 1 addition & 1 deletion examples/whoami.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

async run() {
if (process.env.HEROKU_API_KEY) this.warn('HEROKU_API_KEY is set')
if (!this.heroku.auth) this.notloggedin()
if (!(await this.heroku.getAuth())) this.notloggedin()
try {
const {body: account} = await this.heroku.get<Heroku.Account>('/account', {retryAuth: false})
ux.stdout(account.email)
Expand All @@ -22,5 +22,5 @@
}

(StatusCommand.run([]) as any)
.catch(Errors.handle)

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / lint 

Prefer top-level await over using a promise chain

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / lint 

Expected indentation of 0 spaces but found 2

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 22.x) 

Prefer top-level await over using a promise chain

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 22.x) 

Expected indentation of 0 spaces but found 2

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20.x) 

Prefer top-level await over using a promise chain

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20.x) 

Expected indentation of 0 spaces but found 2

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 20.x) 

Prefer top-level await over using a promise chain

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 20.x) 

Expected indentation of 0 spaces but found 2

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 22.x) 

Prefer top-level await over using a promise chain

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 22.x) 

Expected indentation of 0 spaces but found 2

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (windows-latest, 20.x) 

Prefer top-level await over using a promise chain

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (windows-latest, 20.x) 

Expected indentation of 0 spaces but found 2

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (windows-latest, 22.x) 

Prefer top-level await over using a promise chain

Check warning on line 25 in examples/whoami.ts

View workflow job for this annotation

GitHub Actions / test (windows-latest, 22.x) 

Expected indentation of 0 spaces but found 2

Loading
Loading