Merged
Conversation
Hunspell defaults this flag to 65510 so that words can be marked as forbidden even if the dictionary does not set a `FORBIDDENWORD` flag explicitly. So instead of an `Option<Flag>` this is a `Flag`. This includes a logic change in the suggester to eliminate a check that the forbidden_word_flag is Some. Because of the non-zero default in Hunspell this branch is always `true` and can be removed.
This is the same as `Hunspell::remove`: the given stem is marked with the FORBIDDENWORD flag if it is not already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
This is the same as
Hunspell::remove: it acts on stems rather than full words. (See the doctest for a nice example.) That behavior is a little bit unintuitive so I'm using a slightly more specific name for the function.TODO: how does this interact with
Dictionary::add? Do we need to remove the forbidden_word_flag when adding back a word which was removed? Edit: looks like Hunspell does some extra handling which spellbook does not in add which we could adopt. But that can be done later