Updated the spec_test location and the documentation for the CLI #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the location of the spec_test files and removes the hed-specification submodule reference, consolidating test data into the main repository structure.
Changes:
- Moved spec test data from submodule to main repository
- Added comprehensive validation test files for HED error types
- Removed hed-specification submodule reference
Reviewed changes
Copilot reviewed 44 out of 48 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec_tests/hed-tests/json_test_data/validation_tests/TEMPORAL_TAG_ERROR_DELAY.json | Added test cases for delayed temporal tag validation errors |
| spec_tests/hed-tests/json_test_data/validation_tests/TEMPORAL_TAG_ERROR.json | Added test cases for temporal tag structure and logic errors |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_REQUIRES_CHILD.json | Added test cases for tags requiring child elements |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_NOT_UNIQUE.json | Added test cases for unique tag constraint violations |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_NAMESPACE_PREFIX_INVALID.json | Added test cases for invalid namespace prefix usage |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_INVALID.json | Added test cases for invalid tag validation |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_GROUP_ERROR.json | Added test cases for tag grouping errors |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_EXTENSION_INVALID.json | Added test cases for invalid tag extensions |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_EXTENDED.json | Added test cases for tag extension warnings |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_EXPRESSION_REPEATED.json | Added test cases for repeated tag expressions |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_EMPTY.json | Added test cases for empty tag validation |
| spec_tests/hed-tests/json_test_data/validation_tests/SIDECAR_KEY_MISSING.json | Added test cases for missing sidecar keys |
| spec_tests/hed-tests/json_test_data/validation_tests/SIDECAR_INVALID.json | Added test cases for invalid sidecar structure |
| spec_tests/hed-tests/json_test_data/validation_tests/SCHEMA_LOAD_FAILED.json | Added test cases for schema loading failures |
| spec_tests/hed-specification | Removed submodule reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spec_tests/hed-tests/json_test_data/validation_tests/SCHEMA_LOAD_FAILED.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.