measureText fix for when element.scrollHeight is 0#49
Open
hoseyjoe wants to merge 17 commits intohaxeui:masterfrom
Open
measureText fix for when element.scrollHeight is 0#49hoseyjoe wants to merge 17 commits intohaxeui:masterfrom
hoseyjoe wants to merge 17 commits intohaxeui:masterfrom
Conversation
element.scrollHeight would sometimes return 0 and cause terminal loop issue. I never found repeat but this fixed my code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes in my layout element.scrollHeight would be 0 causing looping issue. This fixes it. I will continue to look for repeat