#371, fix multiline LANGUAGE pragmas#408
Open
bravit wants to merge 2 commits intohaskell-suite:masterfrom
Open
#371, fix multiline LANGUAGE pragmas#408bravit wants to merge 2 commits intohaskell-suite:masterfrom
bravit wants to merge 2 commits intohaskell-suite:masterfrom
Conversation
Previously pragma lines started with non-whitespace characters at the first column produced ParseError.
Collaborator
|
I don't think this is right as you can't write This is a bug in the lexer which I have not being able to fix, similar to all the other issues tagged with "layout" https://github.com/haskell-suite/haskell-src-exts/issues?q=is%3Aissue+is%3Aopen+label%3Alayout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code (multiline LANGUAGE pragma with lines started with non-whitespace characters) :
makes lexer to insert
;in the beginning of every line. This can be fixed by workaround in the parser. The first attempt was made in #217, here I follow the same approach.