fixing mypy's Matcher[Never] #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
draft: adding some quick typechecking tests |
bukzor
had a problem deploying
to
publish-test-release
GitHub Actions
Failure
Member
|
Looks like we'd need to remove 3.8 support to make this work, which I am fine with. |
Author
|
3.8 compat restored. |
bukzor
had a problem deploying
to
publish-test-release
GitHub Actions
Failure
Author
|
Ready for merge, to the best of my ability. |
Author
|
happy monday! |
agentydragon
added a commit
to agentydragon/ducktape
that referenced
this pull request
Jan 15, 2026
PyHamcrest ships py.typed but the annotations mislead mypy (e.g. all_of/only_contains with Union[Matcher[T], T]). Treat the library as Any by skipping imports until upstream fixes land (see hamcrest/PyHamcrest#267).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that manually unrolling these
Union[Matcher[T], T]alternatives into@overloadalternatives allows mypy to properly evaluate them in order, rather than getting confused and giving up (resulting in an inference ofT = Never).Closes: #266 #264
Two off-topic changes included: (you can revert them or ask me to)
uv syncwill now treatPyHamcrest[dev]as itsdev"dependency group"has_entries