Test out a more sophisticated approach to the readiness probe

[kurtmc]

No description provided.

[Copilot]

Pull Request Overview

This PR replaces the TCP-based readiness probe with a more sophisticated shell script-based approach that evaluates multiple conditions to determine node readiness in a Valkey cluster. The new readiness check considers cluster state, slot allocation, node isolation, and a timeout fallback mechanism.

Key Changes:

• Replaced simple TCP readiness probe with an exec probe running a bash script
• Added comprehensive readiness logic that checks multiple conditions (cluster state, slot allocation, single node detection, timeout)
• Expanded readiness probe comparison to evaluate the entire probe configuration instead of just InitialDelaySeconds

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
internal/controller/valkeycluster_controller_statefulset.go	Updated readiness probe from TCPSocket to Exec with new timeout/threshold values and expanded probe comparison logic
internal/controller/valkeycluster_controller_configmap.go	Added readiness.sh script to ConfigMap data
internal/controller/scripts/readiness.sh	New bash script implementing multi-condition readiness checks for Valkey cluster nodes

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Missing quotes around variable expansion. Should be \"$TIMEOUT_SECONDS\" to prevent potential issues if the variable contains spaces or special characters.

Suggested change

	if [ "$uptime" -ge $TIMEOUT_SECONDS ]; then
	if [ "$uptime" -ge "$TIMEOUT_SECONDS" ]; then

[Copilot]

The pattern \"^\" matches every line including empty lines. This could produce incorrect counts if there are blank lines in the output. Use grep -c . or wc -l on non-empty output instead.

Suggested change

	node_count=$(echo "$nodes_info" | grep -c "^")
	node_count=$(echo "$nodes_info" | grep -c .)

[Copilot]

The regex pattern is too permissive and will match single digits without slot ranges. The pattern [0-9]+-?[0-9]* matches single numbers (e.g., '8' in 'field8'). Should use a more specific pattern like '[0-9]+-[0-9]+|^[0-9]+$' or anchor the pattern properly to avoid false positives.

Suggested change

	if ! echo "$myself_line" | grep -qE '\[?[0-9]+-?[0-9]*\]?'; then
	if ! echo "$myself_line" | grep -qE '\b[0-9]+-[0-9]+\b|\b[0-9]+\b'; then