Skip to content

Fix/halter multiplug instantiation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uh-oh-monteiro merged 4 commits into from
Jul 25, 2025
Merged

Fix/halter multiplug instantiation #14

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1eac119
remove call which prematurely tears down multiplug
uh-oh-monteiro Jun 30, 2025
db2329f
remove print statement
uh-oh-monteiro Jun 30, 2025
6f6460c
undo web ui messarounds; why is this here?
uh-oh-monteiro Jul 15, 2025
027926e
Revert "undo web ui messarounds; why is this here?"
uh-oh-monteiro Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions openhtf/plugs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,6 @@ def initialize_plugs(
plug_instance: plug_type
if plug_type in self._unmanaged_plugs:
plug_instance = self._unmanaged_plugs[plug_type]
try:
plug_instance.setUp()
except Exception: # pylint: disable=broad-except
self.tear_down_plugs()
raise
else:
# Create a logger for this plug. All plug loggers go under the 'plug'
# sub-logger in the logger hierarchy.
Expand Down Expand Up @@ -304,7 +299,7 @@ def initialize_plugs(
plug_logger.exception('Exception instantiating plug type %s', plug_type)
self.tear_down_plugs()
raise
self.update_plug(plug_type, plug_instance)
self.update_plug(plug_type, plug_instance)
Copy link

@jonny12375 jonny12375 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo i think the actual fix is to not call update_plug in add_non_managed_plug and tear_down_plugs for the unmanaged plugs, but this theoretically does the same thing. We might run into some edge case later on because the non-managed plugs are added to plugs_by_type and _by_name earlier than the managed plugs, but it's probably fine

Copy link
Author

@uh-oh-monteiro uh-oh-monteiro Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to implement when I've got more time :)

try:
plug_instance.setUp()
except Exception: # pylint: disable=broad-except
Expand Down