adding new regex patterns #883

SecHoussam · 2026-01-24T15:16:41Z

No description provided.

gemini-code-assist · 2026-01-24T15:16:55Z

Summary of Changes

Hello @SecHoussam, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the tool's capability to identify sensitive data by integrating new regular expression patterns. These additions will improve the detection of various API keys and access tokens, thereby strengthening the overall security scanning and helping to prevent the accidental exposure of credentials from a wider range of platforms.

Highlights

New Secret Detection Patterns: This PR introduces several new regular expression patterns to enhance the detection of sensitive information, such as API keys and access tokens, across various services.
Expanded Service Coverage: The added patterns specifically target GitLab, Shopify, Linear, DigitalOcean, Asana, Dropbox, SendGrid, and Firebase, broadening the scope of secrets that can be identified.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Signed-off-by: HAHWUL <[email protected]>

codecov · 2026-01-25T14:15:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

pkg/scanning/grep.go

+	"dalfox-esii":                  `<esii-dalfox>`,
+	"dalfox-rsa-key":               `-----BEGIN RSA PRIVATE KEY-----|-----END RSA PRIVATE KEY-----`,
+	"dalfox-priv-key":              `-----BEGIN PRIVATE KEY-----|-----END PRIVATE KEY-----`,
+	"dalfox-aws-s3":                `s3\.amazonaws.com[/]+|[a-zA-Z0-9_-]*\.s3\.amazonaws.com`,


pkg/scanning/grep.go

+	"dalfox-priv-key":              `-----BEGIN PRIVATE KEY-----|-----END PRIVATE KEY-----`,
+	"dalfox-aws-s3":                `s3\.amazonaws.com[/]+|[a-zA-Z0-9_-]*\.s3\.amazonaws.com`,
+	"dalfox-aws-appsync-graphql":   `da2-[a-z0-9]{26}`,
+	"dalfox-slack-webhook1":        `https://hooks.slack.com/services/T[a-zA-Z0-9_]{8}/B[a-zA-Z0-9_]{8}/[a-zA-Z0-9_]{24}`,


pkg/scanning/grep.go

+	"dalfox-priv-key":              `-----BEGIN PRIVATE KEY-----|-----END PRIVATE KEY-----`,
+	"dalfox-aws-s3":                `s3\.amazonaws.com[/]+|[a-zA-Z0-9_-]*\.s3\.amazonaws.com`,
+	"dalfox-aws-appsync-graphql":   `da2-[a-z0-9]{26}`,
+	"dalfox-slack-webhook1":        `https://hooks.slack.com/services/T[a-zA-Z0-9_]{8}/B[a-zA-Z0-9_]{8}/[a-zA-Z0-9_]{24}`,


pkg/scanning/grep.go

+	"dalfox-aws-s3":                `s3\.amazonaws.com[/]+|[a-zA-Z0-9_-]*\.s3\.amazonaws.com`,
+	"dalfox-aws-appsync-graphql":   `da2-[a-z0-9]{26}`,
+	"dalfox-slack-webhook1":        `https://hooks.slack.com/services/T[a-zA-Z0-9_]{8}/B[a-zA-Z0-9_]{8}/[a-zA-Z0-9_]{24}`,
+	"dalfox-slack-webhook2":        `https://hooks.slack.com/services/T[a-zA-Z0-9_]{8,10}/B[a-zA-Z0-9_]{8,10}/[a-zA-Z0-9_]{24}`,


pkg/scanning/grep.go

+	"dalfox-aws-s3":                `s3\.amazonaws.com[/]+|[a-zA-Z0-9_-]*\.s3\.amazonaws.com`,
+	"dalfox-aws-appsync-graphql":   `da2-[a-z0-9]{26}`,
+	"dalfox-slack-webhook1":        `https://hooks.slack.com/services/T[a-zA-Z0-9_]{8}/B[a-zA-Z0-9_]{8}/[a-zA-Z0-9_]{24}`,
+	"dalfox-slack-webhook2":        `https://hooks.slack.com/services/T[a-zA-Z0-9_]{8,10}/B[a-zA-Z0-9_]{8,10}/[a-zA-Z0-9_]{24}`,


pkg/scanning/grep.go

+	"dalfox-mailgun-api":           `key-[0-9a-zA-Z]{32}`,
+	"dalfox-mailchamp-api":         `[0-9a-f]{32}-us[0-9]{1,2}`,
+	"dalfox-picatic-api":           `sk_live_[0-9a-z]{32}`,
+	"dalfox-google-oauth-id":       `[0-9(+-[0-9A-Za-z_]{32}.apps.qooqleusercontent.com`,


pkg/scanning/grep.go

+	"dalfox-github-access-token":   `[a-zA-Z0-9_-]*:[a-zA-Z0-9_\-]+@github\.com*`,
+	"dalfox-github":                `[gG][iI][tT][hH][uU][bB].*['|"][0-9a-zA-Z]{35,40}['|"]`,
+	"dalfox-gitlab-token":          `glpat-[0-9a-zA-Z-_]{20}`,
+	"dalfox-azure-storage":         `[a-zA-Z0-9_-]*\.file.core.windows.net`,


hahwul

LGTM! Thanks for adding the grep patterns. I made some fixes to the escape sequences in the regex patterns to resolve the build errors.

There are a few more codeql errors right now, so I'll correct the requirements separately!
Thank you again!

SecHoussam added 9 commits January 24, 2026 15:47

add Shopify Access Token

8316eed

add Linear API Key

c7ffea0

add Digital Ocean Token

d906cdc

add Asana Personal Access Token

67ccfcb

add Dropbox Access Token

d134dc8

add SendGrid API Key

ab2e697

add GitLab Token pattern

3e86e64

add Firebase Secret pattern

97ea0e9

Update grep.go

5025a9b

This comment was marked as outdated.

Sign in to view

SecHoussam added 3 commits January 24, 2026 16:24

add Netlify Token pattern

d301982

add Sentry DSN pattern

92b095e

Update grep.go

bbf9569

hahwul added this to the v2.13.0 milestone Jan 25, 2026

Use raw string literals for builtin grep patterns

eb9dce3

Signed-off-by: HAHWUL <[email protected]>

github-advanced-security bot found potential problems Jan 25, 2026

View reviewed changes

hahwul approved these changes Jan 25, 2026

View reviewed changes

hahwul merged commit d5fe123 into hahwul:main Jan 25, 2026
7 of 8 checks passed

hahwul mentioned this pull request Jan 25, 2026

Improve grepping #885

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adding new regex patterns #883

adding new regex patterns #883

SecHoussam commented Jan 24, 2026

Uh oh!

gemini-code-assist bot commented Jan 24, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jan 25, 2026

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

hahwul left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

adding new regex patterns #883

adding new regex patterns #883

Conversation

SecHoussam commented Jan 24, 2026

Uh oh!

gemini-code-assist bot commented Jan 24, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jan 25, 2026

Codecov Report

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Check failure

Uh oh!

Check failure

Check failure

Uh oh!

Check failure

Uh oh!

hahwul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants