fix: avoid duplicate getCurrentState API call in hmip_cli#626
Open
lackas wants to merge 2 commits intohahn-th:masterfrom
Open
fix: avoid duplicate getCurrentState API call in hmip_cli#626lackas wants to merge 2 commits intohahn-th:masterfrom
lackas wants to merge 2 commits intohahn-th:masterfrom
Conversation
When --dump-config is used, the configuration is already downloaded. Reuse this data via update_home() instead of calling get_current_state_async() which would fetch the same data again. Fixes hahn-th#594
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
==========================================
- Coverage 96.78% 91.40% -5.39%
==========================================
Files 49 55 +6
Lines 10298 10309 +11
==========================================
- Hits 9967 9423 -544
- Misses 331 886 +555 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dump-configis used, reuse the already downloaded configuration viaupdate_home()instead of callingget_current_state_async()which fetches the same data againFixes #594