feat: added get form and get all form service (NOT READY FOR REVIEW) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Lindsay-X
commented
Jan 15, 2026
Lindsay-X
commented
- added form route test
- added get all form route and get specific form route
- get all form logic: returns an array of (formId, seasonCode, openTime, closeTime, and tags)
- get specific form logic: returns formId, seasonCode, openTime, closeTime, tags, and responses based on formId in param
- added test for service logic
Lindsay-X
requested review from
BlazingAsher,
danielp1218,
fpunny,
ja-der and
shoexue
danielp1218
requested changes
Jan 16, 2026
src/resources/form/forms.service.ts
Outdated
| .from(form) | ||
| .where(and(eq(form.seasonCode, seasonCode), eq(form.formId, formId))) | ||
| .limit(1); | ||
| const responses = await getFormResponses(seasonCode, formId); |
Contributor
There was a problem hiding this comment.
I believe this was meant to get the questions right? not responses?
src/resources/form/forms.service.ts
Outdated
| const responses = await getFormResponses(seasonCode, formId); | ||
| return formResult[0] | ||
| ? { | ||
| formId: formResult[0].formId, |
Contributor
There was a problem hiding this comment.
if you want you can do ...formResult[0] to just put in all the fields. the only other fields are formName (which should also be returned btw) and eventId (which im gonna remove in #12)
src/resources/form/forms.service.ts
Outdated
| questions?: CreateFormQuestionInput[]; | ||
| } | ||
|
|
||
| export const getForms = async (seasonCode: string, formId?: string) => { |
Contributor
There was a problem hiding this comment.
nit: IMO this should be separated into 2 functions since it returns different types based on whether formId is provided (and since theres no shared logic).
Lindsay-X
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.