fix: Fix imports #343
Open
fix: Fix imports #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-imi
reviewed
Jan 2, 2026
| "regenerator": true | ||
| }], | ||
| [ | ||
| "babel-plugin-transform-rewrite-imports", |
Contributor
There was a problem hiding this comment.
@zoryana94 thank you for addressing this fix!
I think the plugin babel-plugin-transform-rewrite-imports is inside env.esm, so it only runs for the ESM build.
The CJS build uses npm run transpile which doesn't set BABEL_ENV=esm, so the plugin doesn't run.
- dist/esm/hooks/index.js -> "./useHCaptcha.js" ✅
- dist/hooks/index.js -> "./useHCaptcha.jsx" ❌
We may want to move the plugin to the root plugins array instead.
Contributor
There was a problem hiding this comment.
I also opened this other PR as a simpler alternative.
It uses .js extensions directly in the source files instead of relying on a Babel plugin.
No new dependencies, works for both CJS and ESM.
The only tradeoff is a small moduleNameMapper config in Jest to resolve .js -> .jsx during tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.