Skip to content

Conversation

@CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Sep 22, 2025

No description provided.

@CAMOBAP CAMOBAP self-assigned this Sep 22, 2025
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

Cocoapods size report:

OLD: 0 bytes
NEW: 163377 bytes

DIFF: 163377 bytes

Copy link
Contributor

@e271828- e271828- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. left minor comments, also:

JLCore.stop() removes observers + clears sinks but does not unswizzle. if we can't safely do this, should at least document that behavior. if multiple HCaptcha instances call start/stop, can cause stopped-after-one-instance-stops issue.

@CAMOBAP CAMOBAP force-pushed the feature/journeylitics branch from 9369059 to 5f87bdc Compare September 30, 2025 19:52
@CAMOBAP CAMOBAP force-pushed the feature/journeylitics branch from e6e2c04 to f19230c Compare October 21, 2025 19:45
@CAMOBAP CAMOBAP force-pushed the feature/journeylitics branch 2 times, most recently from 4432d36 to 1625e2c Compare November 4, 2025 13:27
@CAMOBAP CAMOBAP marked this pull request as ready for review November 6, 2025 19:03
@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Nov 6, 2025

JLCore.stop() removes observers + clears sinks but does not unswizzle. if we can't safely do this, should at least document that behavior.

unswizzle implemented

if multiple HCaptcha instances call start/stop, can cause stopped-after-one-instance-stops issue.

because we do it on the main thread and in the scope of the single call there should not be a problem swizzle and unswizzle can be considered 'atomic'*

method_exchangeImplementations is not thread safe so I assume other libraries that use the same approach to intercept calls do it on main thread too, so it should not lead to a problems

- Fix all SwiftLint violations (line length, alignment, trailing newlines)
- Increase fastlane pod size limit to 200KB
- Refactor HCaptchaWebViewManager to reduce file size (410→331 lines)
- Fix Carthage Xcode to compile on 14.x version
- Rename userJourneys to userJourney throughout codebase
- Update dictionary key from user_journeys to userJourney
- Add user journey documentation section to README
@CAMOBAP CAMOBAP force-pushed the feature/journeylitics branch from 245219b to e5f1254 Compare November 16, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants