-
Notifications
You must be signed in to change notification settings - Fork 45
feat: user journeys #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: user journeys #195
Conversation
|
Cocoapods size report: |
HCaptcha/Classes/Journeylitics/Hooks/UIGestureRecognizer+JL.swift
Outdated
Show resolved
Hide resolved
e271828-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall. left minor comments, also:
JLCore.stop() removes observers + clears sinks but does not unswizzle. if we can't safely do this, should at least document that behavior. if multiple HCaptcha instances call start/stop, can cause stopped-after-one-instance-stops issue.
9369059 to
5f87bdc
Compare
e6e2c04 to
f19230c
Compare
4432d36 to
1625e2c
Compare
unswizzle implemented
because we do it on the main thread and in the scope of the single call there should not be a problem swizzle and unswizzle can be considered 'atomic'*
|
- Fix all SwiftLint violations (line length, alignment, trailing newlines) - Increase fastlane pod size limit to 200KB - Refactor HCaptchaWebViewManager to reduce file size (410→331 lines) - Fix Carthage Xcode to compile on 14.x version
- Rename userJourneys to userJourney throughout codebase - Update dictionary key from user_journeys to userJourney - Add user journey documentation section to README
245219b to
e5f1254
Compare
No description provided.