Skip to content

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Jan 30, 2026

This API is still used internally in google3.

This reverts commit e6ca417.

RELEASE NOTES: none

This API is still used internally in google3.

This reverts commit e6ca417.
@easwars easwars added Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Bug labels Jan 30, 2026
@easwars easwars added this to the 1.80 Release milestone Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.26%. Comparing base (7985bb4) to head (97d491b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/xds/xdsclient/pool.go 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8869      +/-   ##
==========================================
+ Coverage   82.44%   83.26%   +0.81%     
==========================================
  Files         414      414              
  Lines       32751    32751              
==========================================
+ Hits        27002    27270     +268     
+ Misses       4094     4073      -21     
+ Partials     1655     1408     -247     
Files with missing lines Coverage Δ
internal/xds/bootstrap/bootstrap.go 66.66% <100.00%> (+0.60%) ⬆️
internal/xds/xdsclient/pool.go 83.33% <90.47%> (+21.38%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars easwars merged commit 49e224f into grpc:master Jan 30, 2026
14 of 17 checks passed
@easwars easwars deleted the revert_8829 branch January 30, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants