fix(Group): stop click event propagation to prevent selection reset#65
Merged
fix(Group): stop click event propagation to prevent selection reset#65
Conversation
Clicking on a Group component triggered its selection logic, but the event propagated to the camera component, which resets all selections on click. This caused the group selection to be immediately cleared. Added event.stopPropagation() to the Group's click listener to prevent the event from reaching the camera and preserve the selection state.
Contributor
|
Preview is ready. |
evtaranov
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking on a Group component triggered its selection logic, but the event propagated to the camera component, which resets all selections on click. This caused the group selection to be immediately cleared.
Added event.stopPropagation() to the Group's click listener to prevent the event from reaching the camera and preserve the selection state.