feat(NewBlockLayer, ConnectionLayer): added validation and duplication of blocks by a group#62
Merged
Antamansid merged 2 commits intomainfrom Apr 24, 2025
Merged
Conversation
Contributor
|
Preview is ready. |
draedful
reviewed
Apr 3, 2025
536a20d to
e4e81f6
Compare
draedful
approved these changes
Apr 23, 2025
Collaborator
draedful
left a comment
There was a problem hiding this comment.
Please check the comment.
src/components/canvas/layers/connectionLayer/ConnectionLayer.md
Outdated
Show resolved
Hide resolved
added 2 commits
April 24, 2025 10:55
…n of blocks by a group
e4e81f6 to
fb6c74e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of PR
Key Changes
Connection Validation
isConnectionAllowedfunction to ConnectionLayer that validates if a connection can be created from a source componentBlock Duplication Validation
isDuplicateAllowedfunction to NewBlockLayer that validates if a block can be duplicatedGroup Block Duplication
Technical Improvements
addLayerthat was causing unnecessary graph re-renders