feat(ci): add signed commits for sync-manifest #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch protection requires signed commits, but github-actions[bot] commits aren't GPG signed. This uses iarekylew00t/verified-bot-commit which creates commits via the GitHub API, resulting in automatically verified commits. Changes: - Add branch-name and pr-exists outputs to sync-manifest action - Move commit/push/PR logic from action to workflow (required because composite actions cannot use 'uses:' to call other actions) - Use verified-bot-commit to create signed commits via GitHub API Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Branch protection requires signed commits, but github-actions[bot] commits aren't GPG signed.
In PR #98 (created by the github-actions bot) we see that:
This fix for this uses
iarekylew00t/verified-bot-commitwhich creates commits via the GitHub API, resulting in signed commits that can be merged.This requuires using
verified-bot-commitaction, however the issue is that composite actions can only userun:steps - they cannot useuses:to call other actions. This meant that we had to move the commit/push/PR logic from the composite action to the workflow as part of this PR.Generated with Claude Code