Add function to analyse used labels, and not just used metrics.#232
Draft
Add function to analyse used labels, and not just used metrics.#232
Conversation
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
ea6d96c to
a95ee0f
Compare
replay
reviewed
Jan 6, 2022
| } | ||
|
|
||
| for _, label := range ae.Grouping { | ||
| setInsert(label, &usedLabels.LabelsUsed) |
Contributor
There was a problem hiding this comment.
why not just use a temporary map for the used labels?
Contributor
Author
There was a problem hiding this comment.
No particular reason, I guess I was expecting this list to be short and this to be cheaper than all the allocs associated with maps.
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
Signed-off-by: ShuzZzle <niclas.schad@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR which analyses the usage of labels, and not just metric names. The idea is eventually we'll be able to identify labels we can drop / aggregate way.
Lots of this exists already (great work @gouthamve) but AFAICT only analyses metric names? I plan on just working through this pipeline and updating everything to consider labels too.
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com