This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Ensure namespace is set on all Kubernetes resources#178
Open
RyanW8 wants to merge 5 commits intografana:mainfrom
RyanW8:namespace-issue-177
Open
Ensure namespace is set on all Kubernetes resources#178RyanW8 wants to merge 5 commits intografana:mainfrom RyanW8:namespace-issue-177
RyanW8 wants to merge 5 commits intografana:mainfrom
RyanW8:namespace-issue-177
Conversation
added 2 commits
September 4, 2020 13:11
…ng resources: - Distributor - Memcached - Querier - Query-frontend
Author
|
Fixed conflicts. Can you please merge? |
pstibrany
reviewed
Sep 4, 2020
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
This is a good start, but some resources are still missing namespace.
| * [CHANGE] Add overrides config to tsdb store-gateway. #167 | ||
| * [CHANGE] Ingesters now default to running as `StatefulSet` with WAL enabled. It is controlled by the config `$._config.ingester_deployment_without_wal` which is `false` by default. Setting the config to `true` will yeild the old behaviour (stateless `Deployment` without WAL enabled). #72 | ||
| * [CHANGE] We now allow queries that are 32 days long. For example, rate(metric[32d]). Before it was 31d. #173 | ||
| * [BUGFIX] Add support the `local` ruler client type |
Contributor
There was a problem hiding this comment.
This should not be here -- it's already on top.
Contributor
|
Branch https://github.com/grafana/cortex-jsonnet/tree/pull/178 shows how to add namespaces to more (but still not all) resources. |
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
jtlisi
approved these changes
Sep 9, 2020
Contributor
jtlisi
left a comment
jtlisi
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
|
Ryan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Ensure the namespace defined in _config is set on these resources:
Which issue(s) this PR fixes:
Fixes When generating YAML resources for kubernetes, only some of them have correct namespace set #177
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]