Allowed installation of SimpleSAMLphp modules.#1723
Open
barbun wants to merge 1 commit intogovCMS:3.x-developfrom
Open
Allowed installation of SimpleSAMLphp modules.#1723barbun wants to merge 1 commit intogovCMS:3.x-developfrom
barbun wants to merge 1 commit intogovCMS:3.x-developfrom
Conversation
f034587 to
b00691c
Compare
b00691c to
4217baa
Compare
Contributor
|
@barbun As discussed, I created another PR (govCMS/lagoon#532) for Lagoon to achieve the goal via a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The current
composer.jsonsets:This disables SimpleSAMLphp’s Composer Module Installer — the plugin responsible for automatically installing and registering additional SimpleSAMLphp modules.
As a result, modules such as
simplesamlphp/simplesamlphp-assets-baseare not automatically detected or enabled by SimpleSAMLphp.When using HTTP-POST bindings, SAML authentication data is transmitted via an intermediary form page. Without the
simplesamlphp-assets-basemodule, this form lacks the auto-submit functionality, causing users to get stuck on that intermediary page until they manually submit it.Keeping
"simplesamlphp/composer-module-installer": trueis the recommended approach, ensuring that all SimpleSAMLphp modules (e.g. assets, themes, or authentication handlers) are automatically registered during installation.Proposed Solution
composer.jsonto:simplesamlphp/simplesamlphp-assets-baseto function as intended.