fix: fall back to HTTP/1.1 when global http2 option is enabled #3894
+49
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change mitigates hanging requests reported in #3418 when
google.options({http2: true})is used.Root cause
The hang occurs in the HTTP/2 request path (
googleapis-common) where some GET requests can remain open indefinitely. Since this repo surfaces that path through global options, affected calls appear to hang forever.What changed
GoogleApis.options().http2: trueis provided globally, emit a warning and forcehttp2: false(HTTP/1.1 fallback).Tests
npx mocha build/test/test.options.js --grep "disable http2|not emit warning"npx mocha build/test/test.options.jsNotes
This is a defensive mitigation in
google-api-nodejs-clientuntil a full HTTP/2 transport fix is available downstream.