Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jan 28, 2026

No description provided.

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the code formatting and linting process by integrating Ruff, a high-performance tool, into the project. This change simplifies the development workflow and ensures consistent code style across the codebase.

Highlights

  • Ruff Formatting: This PR introduces Ruff as the primary code formatter, replacing Black and isort in the project. Ruff is a faster alternative that combines formatting and linting.
  • Noxfile Updates: The Nox configuration has been updated to use Ruff for formatting and import sorting. The 'blacken' session is deprecated in favor of the new 'format' session.
  • Code Modernization: Minor code formatting changes across multiple files to adhere to Ruff's standards, enhancing code consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's formatting and linting from black and isort to ruff. The changes primarily involve updating noxfile.py and its template to use ruff commands. The rest of the modifications are formatting adjustments across the codebase applied by ruff. The migration appears to be well-executed. I've pointed out a couple of minor inconsistencies in the new noxfile.py format session where exclude flags were missing, which could lead to unintended formatting of golden files. Otherwise, the changes look good.

Comment on lines +817 to +825
session.run(
"ruff",
"check",
"--select",
"I",
"--fix",
"--line-length=88", # Standard Black line length
*LINT_PATHS,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with other ruff commands in this file and to avoid formatting generated or golden files, it's best to add the exclude flag here as well.

    session.run(
        "ruff",
        "check",
        "--select",
        "I",
        "--fix",
        "--line-length=88",  # Standard Black line length
        *LINT_PATHS,
        "--exclude",
        RUFF_EXCLUDES,
    )

Comment on lines 828 to 833
session.run(
"black",
*BLACK_PATHS,
"--extend-exclude",
BLACK_EXCLUDES,
"ruff",
"format",
"--line-length=88", # Standard Black line length
*LINT_PATHS,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid formatting generated or golden files, the exclude flag should be used here, consistent with other ruff format calls in this file.

Suggested change
session.run(
"black",
*BLACK_PATHS,
"--extend-exclude",
BLACK_EXCLUDES,
"ruff",
"format",
"--line-length=88", # Standard Black line length
*LINT_PATHS,
)
session.run(
"ruff",
"format",
"--line-length=88", # Standard Black line length
*LINT_PATHS,
"--exclude",
RUFF_EXCLUDES,
)

@ohmayr ohmayr force-pushed the asset-library-changes-with-ruff-format branch from 5b73572 to efb7a7d Compare January 28, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant