Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jan 28, 2026

See #2541 for the diff.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the mypy configuration to specify Python version 3.14 for static type checking. This change ensures that the type checker leverages the latest Python features and syntax, helping to maintain code quality and compatibility with newer Python environments.

Highlights

  • Mypy Configuration Update: The python_version setting in mypy.ini has been updated from 3.8 to 3.14.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ohmayr ohmayr changed the title chore: bump mypy version to 3.14 chore: configure mypy to use python 3.14 Jan 28, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the python_version in mypy.ini and several related template files to 3.14, aligning with the goal of bumping the mypy version. The noxfile.py has also been updated to include Python 3.14 in the ALL_PYTHON tuple. However, the gapic/ads-templates/mypy.ini.j2 file retains python_version = 3.7, which creates an inconsistency that should be addressed.

@ohmayr ohmayr marked this pull request as ready for review January 28, 2026 00:25
@ohmayr ohmayr requested a review from a team as a code owner January 28, 2026 00:25
@ohmayr ohmayr requested a review from daniel-sanche January 28, 2026 00:25
@ohmayr ohmayr enabled auto-merge (squash) January 28, 2026 00:34
@ohmayr ohmayr merged commit 72db9d0 into main Jan 28, 2026
139 of 140 checks passed
@ohmayr ohmayr deleted the bump-mypy-to-314 branch January 28, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants