feat: add debug log when sending requests via gRPC#2271
Closed
feat: add debug log when sending requests via gRPC#2271
Conversation
vchudnov-g
force-pushed
the
add-debug-log-grpc-transport
branch
from
b3df060 to
4c73a46
Compare
vchudnov-g
reviewed
Dec 6, 2024
| grpc_response = { | ||
| "payload": type(result).to_json(result), | ||
| "metadata": dict(metadata), | ||
| "status": "OK", |
Contributor
There was a problem hiding this comment.
IIUC, if we get here the status is OK. In case of a gRPC error, an exception is thrown...or do we catch in the lower levels? If so, how do we get the status?
ohmayr
reviewed
Dec 6, 2024
| if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(logging.DEBUG): | ||
| grpc_request = { | ||
| "payload": type(request).to_json(request), | ||
| "requestMethod": "grpc", |
Contributor
There was a problem hiding this comment.
I don't think we need this for gRPC. method and url are rest only fields.
Contributor
There was a problem hiding this comment.
But how will the user looking at the logs know (from the logs only) that this was a gRPC request? They have to reason from not having a URL or method field, or from looking at the metadata. We might as well make it explicit for convenience.
No need to block on this; we can change it later.
product-auto-label
bot
added
size: xl
Contributor
|
As per internal discussions, we'll be splitting this PR into smaller PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/381100907
The changes in this PR are only for unary-unary calls. unary-stream calls still need to be added.